Arm backend: Do not partition view_copy #16005
Conversation
aten::view_copy is now considered no-compute by the partitioner. This prevents the case where a partition is left empty if two view_copy ops cancels each other out, leaving the partition empty. This was the case when running torch_audio_hdemucs_high_musdb(_plus), which made Vela output an error. Additionaly, some incorrectly named tests in test_sum have been renamed from view to sum JIRA: MLETORCH-1535 Change-Id: I1fe5175fd560486a064258dee5f0048836022ee1
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16005
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a5e2d2c with merge base e38734e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Christoffer-JL! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
meta-cla
bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Erik-Lundell
added
partner: arm
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
Erik-Lundell
added
ciflow/trunk
release notes: none
|
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
2 participants
aten::view_copy is now considered no-compute by
the partitioner. This prevents the case
where a partition is left empty if two
view_copy ops cancels each other out,
leaving the partition empty.
This was the case when running
torch_audio_hdemucs_high_musdb(_plus),
which made Vela output an error.
Additionaly, some incorrectly named tests in test_sum have been renamed from view to sum
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai